Add Sugar for Variadics #38787
Merged
Add Sugar for Variadics #38787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to represent the interface type of variadic parameters directly with ArraySliceType. This was awfully convenient for the constraint solver since it could just canonicalize and open [T] to Array<$T> wherever it saw a variadic parameter. However, this both destroys the sugaring of T... and locks the representation to Array<T>. In the interest of generalizing this in the future, introduce VariadicSequenceType. For now, it canonicalizes to Array<T> just like the old representation. But, as you can guess, this is a new staging point for teaching the solver how to munge variadic generic type bindings. rdar://81628287
|
@swift-ci smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to represent the interface type of variadic parameters directly
with ArraySliceType. This was awfully convenient for the constraint
solver since it could just canonicalize and open [T] to Array<$T>
wherever it saw a variadic parameter. However, this both destroys the
sugaring of T... and locks the representation to Array. In the
interest of generalizing this in the future, introduce
VariadicSequenceType. For now, it canonicalizes to Array just like
the old representation. But, as you can guess, this is a new staging
point for teaching the solver how to munge variadic generic type bindings.
rdar://81628287