Fix an edge case in AccessUseDefChainCloner #38792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in does not assert on seeing begin_access
|
@swift-ci smoke test |
atrick
approved these changes
Aug 7, 2021
There was a problem hiding this comment.
This is the problem with failing to preserve access markers. We have countless places in the code that break in rare cases and now require fixing before we can preserve the markers.
In this case, we can live with the bailout. In a separate PR I'll move the canClone check until after we know that the access marker would also need to be cloned (which is not the situation in this test case).
In the long run, the cloner will need to know how to create access scopes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloner cannot handle begin_access yet. Handle this case so that
canCloneUseDefChaindoes not assert.