Fix debug scope for SIL instructions created in LowerHopToActor #38802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pass uses SILBuilder instant to create instructions and does not set SILDebugScope. Due to this, SILVerifier correctly asserts that basic blocks contain non-contiguous lexical scopes at -Onone. The long term fix would be to replace SILBuilder instance in the pass with SILBuilderContext and use SILBuilderWithScope so that such bugs do not come up.
|
@swift-ci test |
|
@swift-ci test windows platform |
atrick
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass uses SILBuilder instant to create instructions and does not
set SILDebugScope.
Due to this, SILVerifier correctly asserts that basic blocks contain non-contiguous
lexical scopes at -Onone.
The long term fix would be to replace SILBuilder instance in the pass with
SILBuilderContext and use SILBuilderWithScope so that such bugs do not come up.