[Distributed] Complete remote actor resolve() implementation in SIL #38823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
commented
Aug 10, 2021
ktoso
commented
Aug 10, 2021
ktoso
commented
Aug 10, 2021
ktoso
commented
Aug 10, 2021
ktoso
commented
Aug 10, 2021
ktoso
commented
Aug 10, 2021
ktoso
commented
Aug 10, 2021
ktoso
commented
Aug 10, 2021
kavon
reviewed
Aug 11, 2021
ktoso
force-pushed
the
wip-inject-lifecycle-ctors-distributed-3
branch
from
d86175d to
25308f5
Compare
1. We're no longer synthesizing the local init. All designated inits of a dist actor must have exactly one ActorTransport parameter. This parameter is used in the init's prologue to initialize some of its members. 2. We're synthesizing a factory function for the resolve initialization, instead of an actor-member named `init` to serve that purpose. As such, much of the earlier infrastructure is no longer needed, etc.
We'd like to support factor initializers for distributed actor types that are synthesized by SILGen. We already do something similar for memberwise initializers for structs. Thus, this patch generalizes that concept into a new BodyKind for AbstractFunctionDecls called BodyKind::SILSynthesize. In addition, to help differentiate the kinds of AFDs that are SILSynthesized into different families for SILGen to recognize, we also have a new enum SILSynthesizeKind to indicate whether it is a memberwise init, etc.
ktoso
force-pushed
the
wip-inject-lifecycle-ctors-distributed-3
branch
from
40fbea3 to
a33f8cd
Compare
SILGenDistributed
ktoso
force-pushed
the
wip-inject-lifecycle-ctors-distributed-3
branch
from
a33f8cd to
829a5d6
Compare
|
@swift-ci please smoke test |
ktoso
changed the title
ktoso
force-pushed
the
wip-inject-lifecycle-ctors-distributed-3
branch
from
517512f to
b4e8bbb
Compare
ktoso
force-pushed
the
wip-inject-lifecycle-ctors-distributed-3
branch
from
1255661 to
a721856
Compare
|
@swift-ci please smoke test and merge |
|
lol and removed the |
ktoso
force-pushed
the
wip-inject-lifecycle-ctors-distributed-3
branch
from
a721856 to
bf37ba6
Compare
|
Actually do need one of those extra ensureDistributedModuleLoaded. |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #38822 [Distributed] Initializer and lifecycle call synthesis via SIL, and pulls in @kavon's work from #38739
I then continued completing the SIL impl to set properties -- almost there...