-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] implement _copyContents for UnsafeRawBufferPointer #38828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Waiting on #38827 for benchmarking. |
@swift-ci please benchmark |
Performance (x86_64): -O
Code size: -OPerformance (x86_64): -Osize
Code size: -OsizePerformance (x86_64): -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's a pretty big missing performance feature.
Implements
_copyContents
forUnsafe[Mutable]RawBufferPointer
, which enables a fast path when filling upArray
orUnsafeMutableBufferPointer<UInt8>
.Resolves SR-9604 (rdar://52529574).