[5.5][SourceKit] Suppress oslog_invalid_log_message diagnostic in live issues #38834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index build skips *all* function bodies, including inlinable. The `OSLogOptimization` pass expects SIL for inlinable bodies and thus outputs a spurious diagnostic for live issues when the `OSLogInterpolation` extension is in a separate module to the log statement. Ignore this for now, but we may need to re-evaluate if this becomes a more widespread problem. Resolves rdar://79100763
|
@swift-ci please test |
akyrtzi
approved these changes
Aug 11, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #38778
The index build skips all function bodies, including inlinable. The
OSLogOptimizationpass expects SIL for inlinable bodies and thusoutputs a spurious diagnostic for live issues when the
OSLogInterpolationextension is in a separate module to the logstatement.
Ignore this for now, but we may need to re-evaluate if this becomes a
more widespread problem.
Resolves rdar://79100763