Skip to content

Handle end_lifetime in SILInstruction::mayRelease #38841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Handle end_lifetime in SILInstruction::mayRelease #38841

merged 1 commit into from
Aug 12, 2021

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Aug 11, 2021 •
edited
Loading

Just hit a case where marking end_lifetime as not releasing, causes other issues in the verifier. Going to add a test and update.

@atrick
Copy link
Contributor

atrick commented Aug 11, 2021

Why is end_lifetime mayRelease? Just to avoid hoisting it above a use? If so, can you add that comment?

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Aug 11, 2021 •
edited
Loading

Just hit a case where marking end_lifetime as not releasing, causes other issues in the verifier. Going to add a test and update.

False alarm. This was a different issue.

@atrick Marking end_lifetime as false for mayRelease in the PR. (My previous comment is due to another issue with end_lifetime. Sorry for the confusion!)

@meg-gupta
Copy link
Contributor Author

@swift-ci test source compatibility

atrick
atrick approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, lgtm

@meg-gupta meg-gupta merged commit f132379 into swiftlang:main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

@nate-chandler nate-chandler Awaiting requested review from nate-chandler

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meg-gupta @atrick