Skip to content

stdlib: SE-0101: remove old syntax #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2016
Merged

stdlib: SE-0101: remove old syntax #3885

merged 2 commits into from
Jul 30, 2016

Conversation

gribozavr
Copy link
Contributor

This finishes the implementation of SE-0101.


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@gribozavr
Copy link
Contributor Author

@swift-ci Please test

@rintaro
Copy link
Member

rintaro commented Jul 30, 2016

/Users/buildnode/jenkins/workspace/swift-PR-osx/swift/validation-test/stdlib/CoreAudio.swift:233:29: error: 'sizeof' is unavailable: use MemoryLayout<T>.size instead.
    capacity: sizeInBytes / sizeof(AudioBufferList.self))
                            ^~~~~~
Swift.sizeof:2:13: note: 'sizeof' has been explicitly marked unavailable here
public func sizeof<T>(_: T.Type) -> Int
            ^

Oops, sorry about that.

@gribozavr gribozavr force-pushed the stdlib-remove-sizeof branch from e11935a to 833854f Compare July 30, 2016 07:38
@gribozavr
Copy link
Contributor Author

@rintaro No problem, thank you for doing the implementation!

@swift-ci Please test

@gribozavr gribozavr merged commit 302a875 into master Jul 30, 2016
@gribozavr gribozavr deleted the stdlib-remove-sizeof branch July 30, 2016 09:00
@rintaro rintaro mentioned this pull request Jul 30, 2016
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants