[Deserialization] Do not assert on a missing witness if allowing errors #38869
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just an assertion - it's already handled on the next line as the requirement as the requirement could have been optional/unavailable. Another found from the stress tester. |
When allowing errors we may have serialized a requirement without a witness, do not assert when deserializing. Resolves rdar://81884767
bnbarham
force-pushed
the
empty-witness-assert
branch
from
8634f37 to
3afb498
Compare
|
@swift-ci please test |
xymus
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When allowing errors we may have serialized a requirement without a
witness, do not assert when deserializing.
Resolves rdar://81884767