Skip to content

[5.5] ModuleInterface: avoid omitting platform names when printing @available #38877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Aug 13, 2021

When printing module interfaces, the Swift compiler used to omit explicit @available attribute for macCatalyst if the introducing OS version number is identical to that of the iOS @available attribute. This is problematic when adding @_originallyDefinedIn attribute for macCatalyst to an interface because the compiler will then complain about missing availability information for macCatalyst. This PR teaches the compiler to always print explicit @available attributes for all platforms in module interfaces.

rdar://81903124

@nkcsgexi nkcsgexi requested a review from a team as a code owner August 13, 2021 20:01
@nkcsgexi nkcsgexi added the r5.5 label Aug 13, 2021
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a25231f

@nkcsgexi
Copy link
Contributor Author

@swift-ci Please clean test Linux platform

@airspeedswift
Copy link
Member

Original: #38874

@nkcsgexi
Copy link
Contributor Author

Thanks! @airspeedswift

@nkcsgexi nkcsgexi merged commit 400e761 into swiftlang:release/5.5 Aug 16, 2021
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants