Skip to content

[ResultBuilders] Improve diagnostics of unsupported variable declarations #38878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2021
Merged

[ResultBuilders] Improve diagnostics of unsupported variable declarations #38878

merged 4 commits into from
Aug 14, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 13, 2021 •
edited
Loading

Tailored diagnostics for:

  • Declarations without explicit initializer
  • lazy, wrapped (e.g. @Wrapper var x: Int), and computed variable declarations
  • variables with observers

Resolves: rdar://81532339

@xedin xedin requested a review from hborla August 13, 2021 20:45
hborla
hborla approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xedin
Copy link
Contributor Author

xedin commented Aug 13, 2021

@swift-ci please smoke test

@xedin xedin merged commit cf71dc9 into swiftlang:main Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @hborla