[SR-15038][Sema] Use locator to propagate information of array, set, dictonary element on check cast constraint #38884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux Platform |
xedin
reviewed
Aug 16, 2021
LucianoPAlmeida
force-pushed
the
SR-15038-array-element
branch
from
a2ae1eb to
4c2c7fc
Compare
xedin
approved these changes
Aug 17, 2021
Sure, I'll adjust it. Thank you for the review =] |
|
Thank you for the fix! |
…ray, set, dictionary) generic elt in CheckedCast constraint and not record extraneous cast fixes for it
LucianoPAlmeida
force-pushed
the
SR-15038-array-element
branch
from
4c2c7fc to
3c60270
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only TMF_ApplyingFix is not enough to propagate information of (set, array, dictionary) element type (which should not record extraneous cast fixes) through unresolved constraint when the element is a type variable that can't still be solved. So to fix this changes the approach to track that via locator element.
Resolves SR-15038.