[build-script] Refactor out BuildScriptInvocation into its own file and out of the top level build-script file. #38885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd out of the top level build-script file. This shrinks the number of lines in build-script by 50% and just makes it easier to read. It will also enable me to refactor parts of it into pieces without touching the main build-script file. This is really library code... build-script itself doesn't care about how BuildScriptInvocation is actually implemented under the hood.
|
@swift-ci python lint |
|
@swift-ci smoke test |
|
@shahmishal I think that the python lint script may be running differently than the one in the lit run. Check out https://ci.swift.org/job/swift-PR-python-lint/223/. My patch didn't even touch compiler_stage! That means that such code got into the tree without the lit python test complaining. |
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shrinks the number of lines in build-script by 50% and just makes it easier
to read. It will also enable me to refactor parts of it into pieces without
touching the main build-script file. This is really library code... build-script
itself doesn't care about how BuildScriptInvocation is actually implemented
under the hood.