[5.5][Property Wrappers] Fix a bug where wrapped arguments were not properly coerced to the wrapper generator input type. #38892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in coerceCallArguments.
…tween wrapped parameters and wrapped properties. This fixes a bug where @autoclosure was not propagated from the wrapper's init(wrappedValue:) to a wrapped argument.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
airspeedswift
approved these changes
Aug 23, 2021
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #38766
This is important for 5.5 because it fixes a SILGen crash.
For wrapped parameters that are initialized at the call-site (i.e. property wrappers with
init(projectedValue:)), the argument needs to be coerced to the wrapper generator input type in CSApply. Otherwise, this leads to a SILGen crash.This change also fixes a bug where
@autoclosurewas not properly propagated frominit(wrappedValue:)to a wrapped argument because the property wrapper initializer was built manually inPropertyWrapperInitializerInfoRequestinstead of going throughSolutionApplicationTarget::maybeApplyPropertyWrapper()which handles@autoclosureinjection around the initial wrapped value for regular wrapped properties.Resolves: rdar://80820408 / SR-14927