[SILOptimizer] Remove auxiliary debug scope in SILDebugInfoGenerator #38917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Generator Previously inside SILDebugInfoGenerator (i.e. `-sil-based-debuginfo` flag) we're removing all `debug_value` and `debug_value_addr` to avoid mixing Swift and SIL source location. But we forgot to handle the source location inside the auxiliary debug variable info in a `alloc_stack` instruction. Which triggered a verification error regarding debug scope mismatch. This patch teaches SILDebugInfoGenerator to remove any auxiliary debug variable scope, if there is any. Which might degrade the debug info quality but we're mostly care about line number in this mode. rdar://81709398
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously inside SILDebugInfoGenerator (i.e.
-sil-based-debuginfoflag) we're removing all
debug_valueanddebug_value_addrto avoidmixing Swift and SIL source location. But we forgot to handle the source
location inside the auxiliary debug variable info in a
alloc_stackinstruction. Which triggered a verification error regarding debug scope
mismatch.
This patch teaches SILDebugInfoGenerator to remove any auxiliary debug
variable scope, if there is any. Which might degrade the debug info
quality but we're mostly care about line number in this mode.
rdar://81709398