Work around issue with inherited Sendable conformance lookup. #38921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit synthesis of `Sendable` conformances for global actor-isolated class types interacts poorly with the conformance lookup table's attempt at modeling inherited conformances, so a `Sendable` conformance will get created and inherited, but is then "missing" when we try to form the actual inherited conformance. The proper fix for this issue is likely to eliminate the modeling of inherited conformances within the conformance lookup table, which introduces a lot of redundance and, apparently, some bugs. For now, patch over the issue to work around a crash. Narrowly works around rdar://81700570.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit synthesis of
Sendableconformances for global actor-isolatedclass types interacts poorly with the conformance lookup table's
attempt at modeling inherited conformances, so a
Sendableconformancewill get created and inherited, but is then "missing" when we try to
form the actual inherited conformance.
The proper fix for this issue is likely to eliminate the modeling of
inherited conformances within the conformance lookup table, which
introduces a lot of redundance and, apparently, some bugs. For now,
patch over the issue to work around a crash.
Narrowly works around rdar://81700570.