[PrintAsObjC] Do not output invalid decls when allowing errors #38923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
bnbarham
force-pushed
the
fix-objc-header-crash
branch
from
e38910f to
6db9e3e
Compare
|
@swift-ci please test |
beccadax
approved these changes
Aug 18, 2021
xymus
approved these changes
Aug 18, 2021
We still want the ObjectiveC header when allowing errors, but make sure to skip printing out any invalid declarations that may be caused because of those errors. In particular, duplicate declarations were causing a crash when sorting declarations where various assumptions would end up casting a non-ExtensionDecl to an ExtensionDecl. Resolves rdar://78023656
bnbarham
force-pushed
the
fix-objc-header-crash
branch
from
6db9e3e to
7b807d5
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still want the ObjectiveC header when allowing errors, but make sure
to skip printing out any invalid declarations that may be caused because
of those errors.
In particular, duplicate declarations were causing a crash when sorting
declarations where various assumptions would end up casting a
non-ExtensionDecl to an ExtensionDecl.
Resolves rdar://78023656