[Tests] Fix a couple of type round trip test problems. #38935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stdlib version of libswiftDemangle doesn't include the node dumper when not building with assertions, but the type round trip test needs it.
|
@swift-ci Please smoke test |
Apparently we can write a type with @convention(block) on Linux, which is entertaining because when we touch the metadata for such a thing in the runtime, we fail with an assert(), assuming assertions are enabled.
al45tair
changed the title
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdlib version of libswiftDemangle doesn't include the node dumper when not building with assertions, but the type round trip test needs it.
Also, on Linux, it appears it's possible to write a type with
@convention(block), but passing that to the runtime causes an assertion failure if assertions are enabled. That's either a compiler bug (@convention(block)should only be allowed if we have ObjC interop), or a runtime bug (it shouldn't fail, but should do something reasonable instead), or both. It still breaks the build, however, so I've added a workaround for now.