Sema: Don't derive witnesses in swiftinterface files #38937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression from swiftlang#36752. Previously, a RawRepresentable enum would use the default implementation of == from a protocol extension in the standard library. After the above PR, we began synthesizing the == operator, just like we do for ordinary enums. However, when type checking an older swiftinterface file, we would still synthesize the declaration and try to use it, even though it would not have existed in the older dylib built with the older compiler. Fix this by not deriving witnesses in swiftinterface files at all. The interface should already explicitly list out all derived witnesses; if one is not listed, it should not be derived, because it does not exist in the dylib. Fixes rdar://problem/80466745.
|
@LucianoPAlmeida I believe this should fix the ABI break from your earlier PR. Please take a look. |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Thank you for fixing this @slavapestov! =] |
|
@swift-ci Please smoke test Linux Platform |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #36752.
Previously, a RawRepresentable enum would use the default implementation
of == from a protocol extension in the standard library. After the above
PR, we began synthesizing the == operator, just like we do for ordinary
enums.
However, when type checking an older swiftinterface file, we would
still synthesize the declaration and try to use it, even though it would
not have existed in the older dylib built with the older compiler.
Fix this by not deriving witnesses in swiftinterface files at all.
The interface should already explicitly list out all derived witnesses;
if one is not listed, it should not be derived, because it does not
exist in the dylib.
Fixes rdar://problem/80466745.