[5.5] LoadableByAddress: fix handling of yield instructions which can result in invalid SIL #38954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in invalid SIL The code to handle yield instructions must be done earlier in `rewriteFunction` because it can add more instructions to the data structures, which also needs to be processed in `rewriteFunction`. https://bugs.swift.org/browse/SR-14994 rdar://77526343
|
@swift-ci test |
rjmccall
reviewed
Aug 23, 2021
tbkka
approved these changes
Aug 24, 2021
This was referenced Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to handle yield instructions must be done earlier in
rewriteFunctionbecause it can add more instructions to the data structures, which also needs to be processed inrewriteFunction.https://bugs.swift.org/browse/SR-14994
rdar://77526343
This is a cherry-pick of #38924