Skip to content

[rebranch] remove unneeded SingleCommandCompilationDatabase #38961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Aug 19, 2021

This is not needed anymore after swiftlang/llvm-project#3183 lands in
stable/20210726

This class will now be provided by LLVM as part of swiftlang/llvm-project#3183

This is not needed anymore after llvm-project#3183 lands in
stable/20210726
@edymtt
Copy link
Contributor Author

edymtt commented Aug 19, 2021

swiftlang/llvm-project#3183

@swift-ci please smoke-test

@edymtt
Copy link
Contributor Author

edymtt commented Aug 19, 2021

swiftlang/llvm-project#3183

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented Aug 19, 2021

swiftlang/llvm-project#3183

@swift-ci please smoke test macOS

@edymtt
Copy link
Contributor Author

edymtt commented Aug 19, 2021

swiftlang/llvm-project#3183

@swift-ci please smoke test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Aug 19, 2021

The test failures for macOS are the same as the rebranch job

15:37:48   Swift(macosx-x86_64) :: Driver/driver-time-compilation.swift
15:37:48   Swift(macosx-x86_64) :: SILGen/let_decls.swift
15:37:48   Swift(macosx-x86_64) :: SILGen/unmanaged_ownership.swift
15:37:48   Swift(macosx-x86_64) :: SILOptimizer/array_element_propagation.sil
15:37:48   Swift(macosx-x86_64) :: SILOptimizer/array_element_propagation_ossa.sil
15:37:48   Swift(macosx-x86_64) :: SILOptimizer/mem2reg.sil
15:37:48   Swift(macosx-x86_64) :: SILOptimizer/mem2reg_ossa.sil
15:37:48   Swift(macosx-x86_64) :: SILOptimizer/super_init.swift
15:37:48   Swift(macosx-x86_64) :: api-digester/compare-dump-binary-vs-interface.swift
15:37:48   Swift(macosx-x86_64) :: api-digester/stability-stdlib-abi-with-asserts.test
15:37:48   Swift(macosx-x86_64) :: api-digester/stability-stdlib-source.swift
15:37:48   Swift(macosx-x86_64) :: stdlib/NewStringAppending.swift

@etcwilde
Copy link
Member

That is the right (or at least known) set of failing tests. That's as close to success as we're going to get until those get fixed.
I'm not clear on "this is not needed anymore" after the other patch lands. Is that referring to this patch or the class deleted in the patch?

@edymtt
Copy link
Contributor Author

edymtt commented Aug 20, 2021

That was referring to the class -- I reworded the PR description for better clarity.

@edymtt edymtt merged commit fc366f0 into swiftlang:rebranch Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants