Switch Test to the Mock SDK #39008
Merged
Switch Test to the Mock SDK #39008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test used to rely on the overlays. There's a lot of problems with that approach 1) The overlays are not meant to be stable 2) AnyObject lookup is... absolutely buck wild 3) And extremely dependent upon platform-specific results. Hence this test has had a rocky history of being turned on and off for various configurations. Anchor it to the mock SDK so we have complete control over its contents across platforms. Resolves rdar://78797454
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test used to rely on the overlays. There's a lot of problems with
that approach
Hence this test has had a rocky history of being turned on and off for
various configurations. Anchor it to the mock SDK so we have complete
control over its contents across platforms.
Resolves rdar://78797454
I'll have a follow-up that tries to remove the 32-bit gates since the mock SDK doesn't care about the KVO shims.