Skip to content

Disable resilience for modules imported by the MemoryBuffer loader. #39032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

adrian-prantl
Copy link
Contributor

The MemoryBuffer loader is used by LLDB during debugging to import binary Swift
modules from .swift_ast sections. Modules imported from .swift_ast sections are
never produced from textual interfaces. By disabling resilience the expression
evaluator in the debugger can directly access private members.

rdar://79462915

A test for this is in LLDB.

@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#3193
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d29253fca312ffe40a8739d64f7bd7357e74b4a3

@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#3193
@swift-ci test

@adrian-prantl adrian-prantl changed the title Disable resilience for modules imported by the MemoryBuffer loader. [DRAFT] Disable resilience for modules imported by the MemoryBuffer loader. Aug 27, 2021
@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#3193
@swift-ci test

@adrian-prantl
Copy link
Contributor Author

FYI, Im not intending to merge this into the 5.5 branch, I just want to test the patch against a stable base line.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 020123f283276ba8c5e84b5f90b5c8f085eafc7d

The MemoryBuffer loader is used by LLDB during debugging to import binary Swift
modules from .swift_ast sections. Modules imported from .swift_ast sections are
never produced from textual interfaces. By disabling resilience the expression
evaluator in the debugger can directly access private members.

rdar://79462915
@adrian-prantl adrian-prantl changed the base branch from release/5.5 to rebranch August 31, 2021 01:26
@adrian-prantl adrian-prantl changed the title [DRAFT] Disable resilience for modules imported by the MemoryBuffer loader. Disable resilience for modules imported by the MemoryBuffer loader. Aug 31, 2021
@adrian-prantl
Copy link
Contributor Author

ping @slavapestov (note that this goes into /rebranch not /5.5)

@adrian-prantl adrian-prantl merged commit fcc77a6 into swiftlang:rebranch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants