Skip to content

[Distributed] Move property synthesis to DerivedConformanceDistributedActor #39046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Aug 25, 2021

We're now able to move the property synthesis to the nicer style of [Distributed] Move property synthesis to "DerivedConformance"

@ktoso ktoso assigned ktoso and unassigned ktoso Aug 25, 2021
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Aug 25, 2021
@ktoso ktoso marked this pull request as draft August 25, 2021 16:52
@ktoso ktoso force-pushed the wip-derive-style branch 2 times, most recently from b712f6c to 9b85b20 Compare August 25, 2021 22:29
@ktoso
Copy link
Contributor Author

ktoso commented Aug 25, 2021

@swift-ci please smoke test

@ktoso ktoso marked this pull request as ready for review August 25, 2021 22:31
@ktoso ktoso force-pushed the wip-derive-style branch from 9b85b20 to abcb4a6 Compare August 25, 2021 22:33
@ktoso
Copy link
Contributor Author

ktoso commented Aug 25, 2021

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-derive-style branch from 964cf68 to 1669fb4 Compare August 26, 2021 09:48
@ktoso
Copy link
Contributor Author

ktoso commented Aug 26, 2021

@swift-ci please smoke test

1 similar comment
@ktoso
Copy link
Contributor Author

ktoso commented Aug 26, 2021

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-derive-style branch from aa2009f to c868bdd Compare August 26, 2021 21:21
@ktoso
Copy link
Contributor Author

ktoso commented Aug 26, 2021

Windows failure was real, the order of deinit and "done" print is not strictly defined, adjusted the test.

@ktoso
Copy link
Contributor Author

ktoso commented Aug 26, 2021

@swift-ci please smoke test and merge

@ktoso
Copy link
Contributor Author

ktoso commented Aug 26, 2021

@swift-ci please smoke test Windows

@ktoso
Copy link
Contributor Author

ktoso commented Aug 26, 2021

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - c868bdd

Install command
tar zxf swift-PR-39046-659-ubuntu16.04.tar.gz
More info

@swift-ci swift-ci merged commit 4681d41 into swiftlang:main Aug 26, 2021
@ktoso ktoso deleted the wip-derive-style branch August 27, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants