[SIL] Added defined flag to begin_borrow. #39050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
lexical_lifetimes/borrow_scope_instruction_flag
branch
from
72cb2bf to
391f2e3
Compare
|
@swift-ci please test |
|
Basically LGTM. Can you add documentation for |
|
Will do! |
nate-chandler
force-pushed
the
lexical_lifetimes/borrow_scope_instruction_flag
branch
from
391f2e3 to
39e8299
Compare
|
@meg-gupta Is this what you had in mind? |
The new flag will be used to track whether a borrow scope corresponds to a source-level lexical scope. Here, the flag is just added to the instruction and represented in textual and serialized SIL.
nate-chandler
force-pushed
the
lexical_lifetimes/borrow_scope_instruction_flag
branch
from
39e8299 to
f3b7706
Compare
|
@swift-ci please test |
nate-chandler
deleted the
lexical_lifetimes/borrow_scope_instruction_flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new flag will be used to track whether a borrow scope corresponds to a source-level lexical scope. Here, the flag is just added to the instruction and represented in textual and serialized SIL.