[Distributed] always emit the distributed thunk #39056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really know why the
!hasFunction
was needed but I think it was copied from other code which was doing it this way.With this guard though we would not emit the thunk in situations where it is necessary and cause missing symbols (missing SIL), like this:
where we'd want the full function:
removing the if solves the issue. I could not reproduce the issue in small files but only in a swiftpm project though, so not super sure how to add a test for it 🤔
(functions from some silly example app)