[DebugInfo] PATCH 2/3: Duplicate logics regarding debug_value_addr #39066
Conversation
|
@swift-ci please test |
lib/IRGen/IRGenSIL.cpp
Outdated
| // utility function to drop it? | ||
| assert(VarInfo && VarInfo->DIExpr); | ||
| auto &DIExpr = VarInfo->DIExpr; | ||
| DIExpr.eraseElement(DIExpr.element_begin()); |
There was a problem hiding this comment.
This looks backwards. We should never emit a debug_value allocstack, op_deref in SILGen/SILOpt instead of unconditionally stripping the operand here.
There was a problem hiding this comment.
You're right, I forgot to change LoadableByAddress to teach it not to attach op_deref if the value is loadable by address.
There was a problem hiding this comment.
just a FYI of how I fixed it: Instead of changing LoadableByAddress Pass, I simply change SILBuiler to teach it not to generate op_deref for debug_value if the SILValue is alloc_stack.
mshockwave
force-pushed
the
dev-debug-val-addr-deprecation-phase2
branch
3 times, most recently
from
3292da9 to
75d430e
Compare
|
@swift-ci please test |
mshockwave
force-pushed
the
dev-debug-val-addr-deprecation-phase2
branch
from
75d430e to
9cad58f
Compare
|
Build failed |
|
Build failed |
This new SIL di-expression represents the dereference on the SSA value. Similar to DW_OP_deref in DWARF. It is also going to replace the existing `debug_value_addr`. Namely, replacing the following instruction: ``` debug_value_addr %a : $*T, name "my_var" ``` with this one: ``` debug_value %a : $*T, name "my_var", expr op_deref ```
mshockwave
force-pushed
the
dev-debug-val-addr-deprecation-phase2
branch
from
9cad58f to
d7a9830
Compare
|
Update test case |
|
Build failed |
This patch replace all in-memory objects of DebugValueAddrInst with DebugValueInst + op_deref, and duplicates logics that handles DebugValueAddrInst with the latter. All related check in the tests have been updated as well. Note that this patch neither remove the DebugValueAddrInst class nor remove `debug_value_addr` syntax in the test inputs.
mshockwave
force-pushed
the
dev-debug-val-addr-deprecation-phase2
branch
from
d7a9830 to
e1023bc
Compare
|
Update a test case in SILOptimizer that hasn't kept up with the previous change of not generating |
This patch replace all in-memory objects of DebugValueAddrInst with
DebugValueInst + op_deref, and duplicates logics that handles
DebugValueAddrInst with the latter. All related check in the tests
have been updated as well.
Note that this patch neither remove the DebugValueAddrInst class nor
remove
debug_value_addrsyntax in the test inputs.This is a PR only for code review. DO NOT MERGE.