[Completion] Remove unused DocWords #39084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rintaro I've left the documentation in the test files for now, do you think it's worth removing them as well (eg. test/Inputs/clang-importer-sdk/usr/include/ctypes.h). |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
The various keyword/recommended/etc fields were parsed and added to completions, but never actually plumbed through SourceKit. Since they're still unused and the implementation is not particularly lightweight, just remove for now. Resolves rdar://82464220
bnbarham
force-pushed
the
remove-keywords
branch
from
1f614de to
8ae8f1d
Compare
|
@swift-ci please test |
rintaro
approved these changes
Aug 28, 2021
Sounds good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various keyword/recommended/etc fields were parsed and added to
completions, but never actually plumbed through SourceKit. Since they're
still unused and the implementation is not particularly lightweight,
just remove for now.
Resolves rdar://82464220