Skip to content

[CMake] Normalize boolean spelling for lit.site.cfg comparisons #39085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

[CMake] Normalize boolean spelling for lit.site.cfg comparisons #39085

merged 1 commit into from
Aug 31, 2021

Conversation

bnbarham
Copy link
Contributor

lit.site.cfg compares various variables to exactly "TRUE". Make sure to
normalize them all so this comparison actually works.

@bnbarham
[CMake] Normalize boolean spelling for lit.site.cfg comparisons
f9a951e 
lit.site.cfg compares various variables to exactly "TRUE". Make sure to
normalize them all so this comparison actually works.
@bnbarham bnbarham requested review from compnerd and gottesmm August 28, 2021 03:59
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

I had a PR test failure that was unsupported locally, turns out my SWIFT_INCLUDE_TOOLS variable was "ON" rather than "TRUE" so it wasn't being added to the available features.

@bnbarham bnbarham merged commit 0a0dcac into main Aug 31, 2021
@bnbarham bnbarham deleted the normalize-bools branch August 31, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @compnerd