Fix an edge case in OSSA RLE for loops #39097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
@swift-ci test macOS Platform |
eeckstein
requested changes
Aug 31, 2021
In OSSA RLE for loops, in certain cases SSAUpdater will not create a new SILPhiArgument to be used as the forwarding value. Based on dominator info it may return the newly copied available value as the forwarding value. This newly copied available value in the dominating predecessor will have destroy values at leaking blocks. Rename makeNewValueAvailable to makeValueAvailable and handle users so that only additional required destroy_values are inserted.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OSSA RLE for loops, in certain cases SSAUpdater will not create a new
SILPhiArgument to be used as the forwarding value. Based on dominator info
it may return the newly copied available value as the forwarding value.
This newly copied available value in the dominating predecessor
will have destroy values at leaking blocks.
Instead of calling makeNewValueAvailable to make this newly copied value available
at the redundant load block, use makeExistingValueAvailable so that only
additional required destroy_values are inserted.