[Concurrency] Propagate Darwin vouchers across async tasks. #39115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeash
force-pushed
the
voucher-propagation
branch
from
a736986 to
9015584
Compare
al45tair
reviewed
Sep 1, 2021
mikeash
force-pushed
the
voucher-propagation
branch
from
9015584 to
6e22423
Compare
|
Updated with naming feedback, less nasal-demon-y access to |
das
reviewed
Sep 2, 2021
mikeash
force-pushed
the
voucher-propagation
branch
from
6e22423 to
c04c587
Compare
das
approved these changes
Sep 2, 2021
|
@swift-ci please test |
|
Build failed |
mikeash
force-pushed
the
voucher-propagation
branch
from
c04c587 to
c6c3dc6
Compare
|
@swift-ci please test |
|
Build failed |
mikeash
force-pushed
the
voucher-propagation
branch
from
c6c3dc6 to
c55c85b
Compare
|
@swift-ci please test |
|
Build failed |
mikeash
force-pushed
the
voucher-propagation
branch
from
c55c85b to
e35e05b
Compare
|
@swift-ci please test |
Darwin OSes support vouchers, which are key/value sets that can be adopted on a thread to influence its execution, or sent to another process. APIs like Dispatch propagate vouchers to worker threads when running async code. This change makes Swift Concurrency do the same. The change consists of a few different parts: 1. A set of shims (in VoucherShims.h) which provides declarations for the necessary calls when they're not available from the SDK, and stub implementations for non-Darwin platforms. 2. One of Job's reserved fields is now used to store the voucher associated with a job. 3. Jobs grab the current thread's voucher when they're created. 4. A VoucherManager class manages adoption of vouchers when running a Job, and replacing vouchers in suspended tasks. 5. A VoucherManager instance is maintained in ExecutionTrackingInfo, and is updated as necessary throughout a Job/Task's lifecycle. rdar://76080222
mikeash
force-pushed
the
voucher-propagation
branch
from
e35e05b to
a80a19b
Compare
|
@swift-ci please test |
al45tair
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darwin OSes support vouchers, which are key/value sets that can be adopted on a thread to influence its execution, or sent to another process. APIs like Dispatch propagate vouchers to worker threads when running async code. This change makes Swift Concurrency do the same.
The change consists of a few different parts:
rdar://76080222