Devirtualize: Skip requirements with covariant 'Self' nested inside a collection #39137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Is a cherry-pick needed for the release branch? |
slavapestov
reviewed
Sep 3, 2021
| // like '[Self]' or '[* : Self]'. | ||
| const Type interfaceTy = wmi->getMember() | ||
| .getDecl() | ||
| ->getInterfaceType() |
There was a problem hiding this comment.
This is just getResultInterfaceType()
There was a problem hiding this comment.
getResultInterfaceType() is not a member of AbstractFunctionDecl, only FuncDecl
There was a problem hiding this comment.
ConstructorDecl and DestructorDecl cannot return a collection of Self though, so FuncDecl is the only relevant case here.
There was a problem hiding this comment.
We need to exclude other covariant positions as well, like init(([Self])->Void).
|
Can you add a test case? |
… collection The devirtualizer does not support handling these yet, which wasn't anticipated in swiftlang#34140
AnthonyLatsis
force-pushed
the
deoptimize
branch
from
e013bbf to
b81db7a
Compare
How does this look? |
|
ping |
slavapestov
approved these changes
Dec 17, 2021
|
Thanks!
I'd love to once SE-309 is completed. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devirtualizer does not support handling these yet, which wasn't anticipated in #34140