Do not build Swift interface files into binary modules when performing a canImport query.
#39139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nkcsgexi
approved these changes
Sep 2, 2021
artemcm
force-pushed
the
DoNotBuildOnCanImport
branch
from
208fc9d to
484a389
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Build failed |
|
Build failed |
…g a `canImport` query. We should hold off actually building the binary module file until it is imported. `canImport` queries can happen, for example, during dependency scanning, when we do not wish to have the scanner tool execute any module builds. Resolves rdar://82603098
artemcm
force-pushed
the
DoNotBuildOnCanImport
branch
from
484a389 to
1b7d555
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should hold off actually building the binary module file until it is imported.
canImportqueries can happen, for example, during dependency scanning, when we do not wish to have the scanner tool execute any module builds.Resolves rdar://82603098