Fix MemoryLifetimeVerifier for enums with empty/non-uniform element types #39173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MemoryLifetimeVerifier currently does not do further analysis when it sees an empty element type or a mismatched element type. But this behaviour is not the same when such element types only have an inject_enum_addr without an init_enum_data_addr. This PR makes this behaviour consistent.
|
@swift-ci test |
meg-gupta
changed the title
eeckstein
reviewed
Sep 6, 2021
|
Actually, I was wrong. The best way to fix this is to handle "empty" payloads like no-payload cases: #39200 |
eeckstein
reviewed
Sep 8, 2021
| br bb3 | ||
|
|
||
| bb3: | ||
| %12 = load [take] %0 : $*Result<Int, Error> |
There was a problem hiding this comment.
I think this should be considered as illegal SIL. This load [take] is loading an uninitialized value (the Int-case coming from bb1). It will not crash, because the only thing which is done is to destroy the value. But still, loading an uninitialized value is not something we should be allowing in SIL.
In my PR (#39200) I have put this test case into memory_lifetime_failures.sil
|
#39200 handles this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryLifetimeVerifier currently does not do further analysis when it sees
an empty element type or a non-uniform element type.
But this behaviour is not the same when such element types only have
an inject_enum_addr without an init_enum_data_addr.
This PR makes this behaviour consistent.