Add -internalize-at-link flag to allow dead stripping and VFE across modules at link time #39214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
reviewed
Sep 9, 2021
lib/IRGen/GenMeta.cpp
Outdated
| @@ -1782,7 +1791,13 @@ namespace { | |||
| // method for external clients. | |||
|
|
|||
| // Emit method dispatch thunk. | |||
| if (hasPublicVisibility(fn.getLinkage(NotForDefinition))) { | |||
| bool shouldEmitDispatchThunk = false; | |||
There was a problem hiding this comment.
Can this logic, which is the same as the previous change, be extracted into a utility function?
There was a problem hiding this comment.
It wasn't entirely identical, so I've instead simplified it into just an or-d expression inside the if.
kubamracek
force-pushed
the
vfe2
branch
3 times, most recently
from
2c2c144 to
97d3f16
Compare
eeckstein
approved these changes
Sep 21, 2021
lib/IRGen/IRGenSIL.cpp
Outdated
| if (IGM.hasResilientMetadata(classDecl, ResilienceExpansion::Maximal)) { | ||
| shouldUseDispatchThunk = true; | ||
| } else if (IGM.getOptions().VirtualFunctionElimination) { | ||
| // For VFE, use a thunk if the target class is in another module. |
There was a problem hiding this comment.
Can you add a comment why this is needed?
kubamracek
force-pushed
the
vfe2
branch
2 times, most recently
from
71f21d2 to
69bef5e
Compare
…modules at link time - Under -internalize-at-link, stop unconditionally marking all globals as used. - Under -internalize-at-link, restrict visibility of vtables to linkage unit. - Emit virtual method thunks for cross-module vcalls when VFE is enabled. - Use thunks for vcalls across modules when VFE is enabled. - Adjust TBDGen to account for virtual method thunks when VFE is enabled. - Add an end-to-end test case for cross-module VFE.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit in the PR is being reviewed at #39128. Suggestion for reviewers is to only look at the second commit here.