Expose __SwiftNativeNSString for Foundation's use, as well as an initializer to create Strings from them #39229
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Catfish-Man
force-pushed
the
bridge-collusion
branch
from
6840c58 to
c2acc41
Compare
Catfish-Man
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please smoke benchmark |
|
Marking this as a draft until I see if the devirtualizer is clever enough to do what I wanted |
|
@swift-ci please smoke test |
…ializer to create Strings from them
Catfish-Man
force-pushed
the
bridge-collusion
branch
from
5639270 to
30a3b6d
Compare
|
@swift-ci please smoke test |
| @@ -658,7 +658,7 @@ internal func _SwiftCreateBridgedString_DoNotCall( | |||
| // This allows us to subclass an Objective-C class and use the fast Swift | |||
| // memory allocator. | |||
| @objc @_swift_native_objc_runtime_base(__SwiftNativeNSStringBase) | |||
| class __SwiftNativeNSString { | |||
| @_spi(Foundation) public class __SwiftNativeNSString { | |||
There was a problem hiding this comment.
Trying to minimize the ABI exposure here. I could expose __StringStorage and __SharedStringStorage, but since this is their superclass, I would need to expose it anyway, and this is sufficient for hanging @objc implementations off of that operate in terms of the new initializer.
| @@ -33,6 +33,7 @@ | |||
| "StringRangeReplaceableCollection.swift", | |||
| "StringGutsRangeReplaceable.swift", | |||
| "StringStorage.swift", | |||
| "StringStorageBridge.swift", | |||
There was a problem hiding this comment.
This was apparently missing all along, who knew.
| extension String { | ||
| @available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) | ||
| @_spi(Foundation) | ||
| public init?(_nativeStorage: AnyObject) { |
There was a problem hiding this comment.
What is this used for, and is this tested anywhere? Comments? That's a lot of unsafe unchecked downcasts and it's not clear to me what is assumed about _nativeStorage.
No description provided.