[WIP] Protocol conformance decoder #39246
Draft
+1,312
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! |
This was much easier to understand with an example to look at. Add the example to the documentation to help future readers.
This is to match the decodeMangledType function that already exists.
For protocol conformance demangling, we will need to be able to fetch a ProtocolConformanceDescriptor given a protocol and a type that might conform to that protocol. Add a function to do that, as well as a cache for that function's results. rdar://46280860
MetadataReader should expose the builder's protocol conformance related types, and should provide a method to demangle a mangled protocol conformance. rdar://46280860
Complete the DecodedMetadataBuilder implementation of protocol conformance demangling. rdar://46280860
Added:
* Demangle node types for the various symbolic manglings.
* SymbolicReferenceKind values for the symbolic manglings.
* A method on the demangler to demangle a conformance.
* Support for printing the new node types.
* Remangler support for the new node types.
* Code to the runtime to deal with the symbolic references.
* A private _getAssocWitnessTableFromMangledName() function to use
from Metadata.cpp.
Use the demangler from swift_getAssociatedConformanceWitnessSlowImpl(),
rather than the existing hack.
Also rebased on current swift/main.
rdar://46280860
al45tair
force-pushed
the
protocol-conformance-decoder
branch
from
e3a6bef to
29bc118
Compare
…able swift_unreachable() needs to be a macro, otherwise the message isn't expanded by the assert() call, and the line number mentioned in the assert() is the one in the header file, making it rather less useful in figuring out what went wrong.
The new demangleConformance() method needs to allow the accessor nodes that are generated by the temporary mangling used in older code. rdar://46280860
Rather than generating accessor functions, use the new support for demangling. This also required some changes to the keypath code in the Swift standard library, which was relying on the symbolic accessor mangling to support witness tables. rdar://46280860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for protocol conformance demangling.
rdar://46280860