[Sema][SR-15179] Ignore FunctionArgument inout mismatch if there is already a fix for locator

[LucianoPAlmeida]

Just ignore the inout fix for individual FunctionArgument if there is a fix already in place.

Resolves: SR-15179
Resolves: rdar://problem/82924296

[hamishknight]

Thanks for fixing this! This looks good to me, though I'll let Pavel have the final say.

I meant to add this to the original bug report, but there are also a couple of other similar cases that also need fixing, e.g:

func tuplify<Ts>(_ fn: (Ts) -> Void) {}
func fn(x: Int..., y: Int...) {}
tuplify(fn)

actor A {}
func isolatedFn(_ x: isolated A, _ y: isolated A) {}
tuplify(isolatedFn)

Both calls to tuplify will emit duplicate diagnostics.

If you want to take a look at fixing these too (either in this PR or a follow-up), I can edit the original bug report to include them, or otherwise file a new bug if you want.

[LucianoPAlmeida]

Thanks for fixing this! This looks good to me, though I'll let Pavel have the final say.

I meant to add this to the original bug report, but there are also a couple of other similar cases that also need fixing, e.g:

func tuplify<Ts>(_ fn: (Ts) -> Void) {}
func fn(x: Int..., y: Int...) {}
tuplify(fn)

actor A {}
func isolatedFn(_ x: isolated A, _ y: isolated A) {}
tuplify(isolatedFn)

Both calls to tuplify will emit duplicate diagnostics.

If you want to take a look at fixing these too (either in this PR or a follow-up), I can edit the original bug report to include them, or otherwise file a new bug if you want.

Ah sure, is the same issue so I think we can include them in the same SR and I can adjust in this PR no problem :)

[xedin]

@swift-ci please smoke test

[LucianoPAlmeida]

@swift-ci Please smoke test

[xedin]

@swift-ci please smoke test Windows platform

[LucianoPAlmeida]

@swift-ci Please smoke test MacOS platform