Skip to content

Enable concurrency runtime tests to run in back-deployed configurations #39284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

DougGregor
Copy link
Member

Rather than blanket-disabling concurrency tests when we aren't using a
just-built concurrency library, enable them whenever we have a
suitable concurrency runtime, either just-built, in the OS, or via the
back-deployment libraries.

This is a significant improvement to our test coverage for
back-deployed concurrency.

…e is there

`concurrency_runtime` covers all three cases of the concurrency runtime
being available:
* Build locally and we're using that version
* Guaranteed available in the OS (e.g., run OS is macOS >= 12, iOS >= 15, etc.)
* Available via back-deployment libraries (macOS >= 10.15, iOS >= 13, etc.)
Rather than blanket-disabling concurrency tests when we aren't using a
just-built concurrency library, enable them whenever we have a
suitable concurrency runtime, either just-built, in the OS, or via the
back-deployment libraries.
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

Note that this passing for back-deployed configurations depends on a few other in-flight PRs:

And there is one test (test/Concurrency/Runtime/exclusivity.swift) that is disabled in
back-deployed configurations.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3ee09a2

@DougGregor
Copy link
Member Author

@swift-ci please test Linux

@DougGregor DougGregor merged commit 6cf40d3 into swiftlang:main Sep 14, 2021
@DougGregor DougGregor deleted the concurrency-backdeploy-tests branch September 14, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants