Stop using 'no_dead_strip' Mach-O section attribute on __swift5_protos, __swift5_proto, __swift5_types sections #39312
Conversation
|
@swift-ci please test |
|
@please test Windows platform |
|
@swift-ci please test Windows platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
I don't see the harm in leaving this. More importantly, it avoids complications in the section attribute merging in LLVM. |
Good point, but I actually do need to drop this "no_dead_strip" attribute from the section, for #39313. Suggestions? |
|
Can we put that as the motivation into the commit message? That along with a check to verify that the symbols are marked with |
kubamracek
force-pushed
the
no-no-dead-strip
branch
from
9b8fac9 to
9f67d0b
Compare
|
Added test, improved commit message. |
|
@swift-ci please test |
|
Build failed |
…s, __swift5_proto, __swift5_types sections This is needed to for a future change, <swiftlang#39313>, which will start to allow under certain conditions to dead-strip unused types, protocols and conformances.
kubamracek
force-pushed
the
no-no-dead-strip
branch
from
9f67d0b to
f3e564c
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
This is needed to for a future change, <apple#39313>, which will start to allow
under certain conditions to dead-strip unused types, protocols and conformances.
The globals emitted into these sections are already marked as used via
addUsedGlobal()so they have desired "no dead stripping" effect already.