Skip to content

Add a SWIFT_STDLIB_HAS_STDIN flag to compile out the readLine API (for the 'freestanding' preset) #39332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2021
Merged

Add a SWIFT_STDLIB_HAS_STDIN flag to compile out the readLine API (for the 'freestanding' preset) #39332

merged 1 commit into from
Sep 17, 2021

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

compnerd
compnerd approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im mostly good with this - I just wish that the commit message could be a bit better. Namely, it is very confusing because deadline is a library, and it's easy to mixup readLine and readline. But, not sure how much better we could do (perhaps the quoting is the best we can do?). FWIW, I think that this would be useful for other environments as well (e.g. Android) where stdin is meant to be inaccessible.

@kubamracek
Add a SWIFT_STDLIB_HAS_STDIN flag to compile out the Swift.readLine()…
6bd7cd3 
… API from the stdlib (for the 'freestanding' preset)
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6bd7cd3

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6bd7cd3

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6bd7cd3

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6bd7cd3

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@kubamracek kubamracek merged commit 6766824 into swiftlang:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@mikeash mikeash mikeash approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@kylemacomber kylemacomber Awaiting requested review from kylemacomber

@Catfish-Man Catfish-Man Awaiting requested review from Catfish-Man

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubamracek @swift-ci @compnerd @mikeash