Skip to content

(v)asprintf is supposed to set the returned pointer to NULL if printing fails, let's fix that in swift_vasprintf #39338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2021
Merged

(v)asprintf is supposed to set the returned pointer to NULL if printing fails, let's fix that in swift_vasprintf #39338

merged 1 commit into from
Sep 17, 2021

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

tbkka
tbkka approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7950ce2

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@kubamracek kubamracek merged commit 1142f61 into swiftlang:main Sep 17, 2021
@kubamracek kubamracek deleted the vasprintf-return-null branch September 17, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

@tbkka tbkka tbkka approved these changes

@compnerd compnerd Awaiting requested review from compnerd compnerd is a code owner

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubamracek @swift-ci @mikeash @tbkka