Add a BorrowedLifetimeExtender utility. #39357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle SSA update (phi creation) when extending an owned lifetime over a borrowed lifetime. This is a layer of logic above BorrowedValue but below OwnershipLifetimeExtender and other higher-level utilities.
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle SSA update (phi creation) when extending an owned lifetime over
a borrowed lifetime.
This is a layer of logic above BorrowedValue but below
OwnershipLifetimeExtender and other higher-level utilities.
Required for OSSA-SimplifyCFG and general guaranteed phi handling.
Unit tests are being developed in a branch that already makes use of this utility, but that depends on rewriting other utilities, which is too much for one PR.
This is a stand-alone utility that can be used independently. It will also replace a large chunk of RAUW helper logic. In general, we need to break up the OSSA utilities into small self-contained pieces that can be used to build other utilities.