Skip to content

Remove duplicated import in Metada unit test #39369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2022
Merged

Remove duplicated import in Metada unit test #39369

merged 2 commits into from
Jan 10, 2022

Conversation

AgranatMarkit
Copy link
Contributor

I'm find duplicated import and want to remove it.

@AgranatMarkit AgranatMarkit changed the title Remove duplicated import of Metadata header Remove duplicated import in Metada.cpp Sep 19, 2021
@AgranatMarkit AgranatMarkit changed the title Remove duplicated import in Metada.cpp Remove duplicated import in Metada unit test Sep 19, 2021
@AgranatMarkit
Copy link
Contributor Author

@swift-ci Please smoke test

@AgranatMarkit AgranatMarkit marked this pull request as draft September 20, 2021 19:01
@AgranatMarkit AgranatMarkit reopened this Sep 20, 2021
@AgranatMarkit AgranatMarkit marked this pull request as ready for review September 20, 2021 19:01
@WowbaggersLiquidLunch

This comment has been minimized.

Sign in to view
2 similar comments
@WowbaggersLiquidLunch

This comment has been minimized.

Sign in to view
@WowbaggersLiquidLunch

This comment has been minimized.

Sign in to view
@WowbaggersLiquidLunch
Copy link
Contributor

@swift-ci Please smoke test

Only those with commit access can summon the CI bot.

I have commit access, but somehow I'm not able to trigger the tests on your behalf. You probably need someone else with commit access to do it for you.

@AgranatMarkit
Copy link
Contributor Author

@WowbaggersLiquidLunch Thank you for response anyway.

@WowbaggersLiquidLunch
Copy link
Contributor

@jckarter I see you're the code owner for "everything in Swift not covered by someone else". Could you help trigger the tests and review this PR?

@WowbaggersLiquidLunch
Copy link
Contributor

@swift-ci please smoke test

WowbaggersLiquidLunch
WowbaggersLiquidLunch approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@WowbaggersLiquidLunch WowbaggersLiquidLunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though I'm not knowledgable with the runtime, nor this file in particular, the change is obviously correct in my opinion

@WowbaggersLiquidLunch
Copy link
Contributor

WowbaggersLiquidLunch commented Jan 10, 2022 •
edited
Loading

@AgranatMarkit do you think this is ready to be merged?

@AgranatMarkit
Copy link
Contributor Author

AgranatMarkit commented Jan 10, 2022 •
edited
Loading

@AgranatMarkit do you think this is ready to be merged?

Yes i do.

@WowbaggersLiquidLunch WowbaggersLiquidLunch merged commit e96215c into swiftlang:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WowbaggersLiquidLunch WowbaggersLiquidLunch WowbaggersLiquidLunch approved these changes

@jckarter jckarter Awaiting requested review from jckarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgranatMarkit @WowbaggersLiquidLunch