Introduce a module alias option to the frontend #39376
Conversation
|
@swift-ci smoke test |
| @@ -498,6 +503,40 @@ bool ArgsToFrontendOptionsConverter::setUpImmediateArgs() { | |||
| return false; | |||
| } | |||
|
|
|||
| bool ArgsToFrontendOptionsConverter::computeModuleAliases() { | |||
| auto list = Args.getAllArgValues(options::OPT_module_alias); | |||
| if (!list.empty()) { | |||
There was a problem hiding this comment.
Nit: If the list is empty, the loop will run zero times. Will that have the same effect as skipping the loop?
There was a problem hiding this comment.
Leaving this check as is since I'm allocating a lambda.
|
One other thing: There should probably be tests for this PR. Since you haven't actually started implementing the feature, these would probably just check that you're catching ill-formed |
|
@swift-ci smoke test |
| // Tests for invalid module alias format and values. | ||
|
|
||
| // RUN: not %target-swift-frontend -emit-silgen -parse-as-library %S/Inputs/invalid-module-alias.swift -module-name foo -module-alias foo=bar 2>&1 | %FileCheck -check-prefix=INVALID_MODULE_ALIAS %s | ||
| // INVALID_MODULE_ALIAS: error: invalid module alias "foo"; make sure the alias differs from the module name, module ABI name, module link name, and a standard library name |
There was a problem hiding this comment.
Is a standard library name possible value only Swift in practice or does it concern other core libraries? If it has just one possible value we could pass down the string value of STDLIB_NAME in the diagnostic.
There was a problem hiding this comment.
I meant to make it sound more general, so names like lib- are not passed in either.
| Diags.diagnose(SourceLoc(), diag::error_module_alias_forbidden_name, value); | ||
| return false; | ||
| } | ||
| if (!Lexer::isIdentifier(value)) { |
There was a problem hiding this comment.
Does that mean that emojis are accepted? 🤔
There was a problem hiding this comment.
Good point :) It's the same checked used by computing module name. Most likely a c99 identifier will be used in practice, but we can add a check to enforce that later if needed.
Validate input and set up the module alias map rdar://83316886
More specific diag msgs Add tests
|
@swift-ci smoke test |
|
@swift-ci smoke test |
Introduce a module alias option to the frontend. Validate and convert the input to a module alias map to be used by import resolution and sema. rdar://83316886
Validate the module alias input and format and convert to the module alias map to be used by import resolution and sema. Rdar://83316886