[cxx-interop] A few misc. changes from #38675. #39432
Conversation
zoecarver
requested review from
slavapestov,
hyp,
beccadax,
egorzhdan and
guitard0g
zoecarver
force-pushed
the
lazy-pt4-misc-changes
branch
from
1a83b4a to
60e7a18
Compare
These should be obviously correct changes. These issues are exposed by our test suite after swiftlang#38675 is applied.
zoecarver
force-pushed
the
lazy-pt4-misc-changes
branch
from
60e7a18 to
0adf067
Compare
|
@swift-ci please smoke test. |
|
This isn't technically a non-functional change, so I'm going to wait at least until tonight to merge it. This way people have a chance to respond if they want to. |
| // We don't support those, yet. | ||
|
|
||
| if (auto functionTemplate = dyn_cast<clang::FunctionTemplateDecl>(D)) | ||
| functionDecl = functionTemplate->getAsFunction(); |
There was a problem hiding this comment.
Since VisitFunctionTemplateDecl already calls this logic with decl->getAsFunction(), I think this line won't be executed. Are you planning to tweak VisitFunctionTemplateDecl to import decl as is, not as decl->getAsFunction()?
There was a problem hiding this comment.
Yeah, I don't think this path is taken yet. This is needed for lazy member loading, when we import the name of every NamedDecl member.
I'm not going to remove decl->getAsFunction yet as it is still needed for some non-operator cases. But that might be a good follow up.
|
Thanks for the review, Egor. I'm going to land this now. If anyone has other comments, I'm happy to make changes in a follow up commit. |
These should be obviously correct changes. These issues are exposed by our test suite after #38675 is applied.