New escape analysis, implemented in libswift #39438
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
changed the title
eeckstein
force-pushed
the
new-escape-analysis
branch
from
765fa07 to
086d40f
Compare
lattner
reviewed
Sep 25, 2021
There was a problem hiding this comment.
Super drive-by, feel free to ignore: this patch is doing a bunch of different things at the same time that don't have much to do with the commit message - including introducing custom versions of the effects attribute, adding new passes for dumping escape analysis, and adding new bindings.
I'd recommend breaking this up into different commits, and also dropping the commented out and #if 0'd code.
|
This PR is not meant to be merged as is. When the code is ready, I'll create new PR's anyway |
eeckstein
force-pushed
the
new-escape-analysis
branch
from
086d40f to
2b799aa
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
3 times, most recently
from
6e28e92 to
05dcba8
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
3 times, most recently
from
45bcdfd to
f5ecba1
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
4 times, most recently
from
1ce540b to
bf052fa
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
2 times, most recently
from
4864770 to
7c46dc9
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
from
7c46dc9 to
aa77ac2
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
from
aa77ac2 to
15d51db
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
from
93059ed to
5bf77e0
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
3 times, most recently
from
a4c3697 to
787e423
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
3 times, most recently
from
479b2aa to
1f3983a
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
from
1f3983a to
1780404
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
from
1780404 to
3739677
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
5 times, most recently
from
9c6c445 to
6bde437
Compare
eeckstein
force-pushed
the
new-escape-analysis
branch
5 times, most recently
from
c889998 to
f41cb80
Compare
It uses the new EscapeInfo.
eeckstein
force-pushed
the
new-escape-analysis
branch
from
f41cb80 to
b5456d0
Compare
|
Closing in favor of #42530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial draft of a new escape analysis, implemented in libswift.
It consists of 4 main parts: