Skip to content

🍒 [5.5][Concurrent] Warnings/errors should use "sendable" not "concurrent" #39453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Sep 24, 2021

Explanation: Some warnings were still using the "non-concurrent" wording about functions and closures. This was wording from before Sendable was a thing. This PR fixes the wording.
Risk: Low.
Reviewed By: @DougGregor
Testing: PR testing and CI on main. Tests adjusted to check for new wording.
Radar: rdar://83416205
Original PR: #39406 [Concurrent] Warnings/errors should use "sendable" not "concurrent"

@ktoso ktoso requested a review from a team as a code owner September 24, 2021 22:46
@ktoso
Copy link
Contributor Author

ktoso commented Sep 24, 2021

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Sep 27, 2021

Windows:


  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:12 (project)


-- Configuring incomplete, errors occurred!

@ktoso
Copy link
Contributor Author

ktoso commented Sep 27, 2021

@swift-ci please test Windows

@ktoso
Copy link
Contributor Author

ktoso commented Sep 27, 2021

@swift-ci please nominate

@ktoso
Copy link
Contributor Author

ktoso commented Sep 27, 2021

Failures on windows unrelated:


Failed Tests (3):
  Swift(windows-x86_64) :: Interop/C/modules/print-qualified-clang-types/print-qualified-clang-types-spi.swift
  Swift(windows-x86_64) :: Interop/Cxx/operators/member-inline-module-interface.swift
  Swift-Unit :: SourceKit/SwiftLang/./SourceKitSwiftLangTests.exe/EditTest.AnnotationsAfterEdit

@ktoso ktoso merged commit b4a97de into swiftlang:release/5.5 Sep 27, 2021
@ktoso ktoso deleted the wip-pick-wip-sendable-fixups branch September 27, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants