[SymbolGraph] Determine optional requirement by presence of OptionalAttr #39456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bitjammer
requested changes
Sep 25, 2021
bnbarham
force-pushed
the
sg-optional-requirement
branch
from
11713d9 to
bcde9b3
Compare
|
Updated with what I had in my comment. Is there a way to sort the JSON output or is |
|
@swift-ci please test |
Rather than checking the underlying ObjectiveC decl, use the presence of `OptionalAttr` to determine if a requirement is optional instead. This is already added by the importer when necessary. An added benefit here is that this also works for optional requirements defined in Swift (ie. `@objc optional ...`).
bnbarham
force-pushed
the
sg-optional-requirement
branch
from
bcde9b3 to
6aa3e0f
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than checking the underlying ObjectiveC decl, use the presence of
OptionalAttrto determine if a requirement is optional instead. Thisis already added by the importer when necessary. An added benefit here
is that this also works for optional requirements defined in Swift (ie.
@objc optional ...).