[ResultBuilders] A couple pattern matching fixes to make it consistent with TypeCheckPattern
#39458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext Tuple splat/implosion is (still) allowed for patterns (with a warning in Swift 5) so we need to use `SingleApply` while looking up members to make sure that e.g. `case test(x: Int, y: Int)` gets the labels preserved when matched with `case let .test(tuple)` and `Compound` when associated values form a tuple pattern.
…for paren patterns A single paren pattern becomes a labeled tuple pattern e.g. `case .test(let value):` should be able to match `case test(result: Int)`. Note that it also means that: `cast test(result: (String, Int))` would be matched against e.g. `case .test((let x, let y))` but that fails during pattern coercion (behavior consistent with what happens in `TypeCheckPattern`).
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Oct 1, 2021
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuple splat/implosion is (still) allowed for patterns (with a warning in Swift 5)
so we need to use
SingleApplywhile looking up members to make sure that e.g.case test(x: Int, y: Int)gets the labels preserved when matched withcase let .test(tuple)andCompoundwhen associated values form a tuple pattern.TypeCheckPatternfor paren patternsA single paren pattern becomes a labeled tuple pattern e.g.
case .test(let value):should be able to match
case test(result: Int). Note that it also means that:cast test(result: (String, Int))would be matched against e.g.case .test((let x, let y))but that fails during pattern coercion (behavior consistent with what happens in
TypeCheckPattern).